mxm commented on code in PR #13883:
URL: https://github.com/apache/iceberg/pull/13883#discussion_r2293314242
##########
flink/v2.0/flink/src/main/java/org/apache/iceberg/flink/sink/dynamic/TableUpdater.java:
##########
@@ -90,6 +109,53 @@ private void findOrCreateTable(TableIdentifier identifier,
Schema schema, Partit
}
}
+ private void updateTablePropertiesIfNeeded(TableIdentifier identifier) {
Review Comment:
This check isn't that expensive:
1. Table properties are cached
2. There aren't any calls to the UpdateProperties API if properties for the
table did not change
3. Also, if there is no handler specified, this check will be skipped
entirely (feature is disabled then)
> Can we avoid this check for every DynamicRecord , where users have
TablePropertiesUpdater to not vary/depend on currentProperties of the table ?
We can certainly do that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
