swapna267 commented on code in PR #13883:
URL: https://github.com/apache/iceberg/pull/13883#discussion_r2291694297
##########
flink/v2.0/flink/src/main/java/org/apache/iceberg/flink/sink/dynamic/TableUpdater.java:
##########
@@ -90,6 +109,53 @@ private void findOrCreateTable(TableIdentifier identifier,
Schema schema, Partit
}
}
+ private void updateTablePropertiesIfNeeded(TableIdentifier identifier) {
Review Comment:
This is basically run for every DynamicRecord right ?
Can we avoid this check for every DynamicRecord , where users have
TablePropertiesUpdater to not vary/depend on currentProperties of the table ?
Like i am thinking if possible to extend the TablePropertiesUpdater
interface to also have needsRefresh() that can default to true. But users can
have less expensive checks (ex: false for first record of a table in a task).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
