ebyhr commented on code in PR #13880:
URL: https://github.com/apache/iceberg/pull/13880#discussion_r2292607594
##########
spark/v3.4/spark/src/test/java/org/apache/iceberg/spark/source/TestSparkMetadataColumns.java:
##########
@@ -90,23 +90,15 @@ public class TestSparkMetadataColumns extends TestBase {
@Parameters(name = "fileFormat = {0}, vectorized = {1}, formatVersion = {2}")
public static Object[][] parameters() {
- return new Object[][] {
- {FileFormat.PARQUET, false, 1},
- {FileFormat.PARQUET, true, 1},
- {FileFormat.PARQUET, false, 2},
- {FileFormat.PARQUET, true, 2},
- {FileFormat.PARQUET, false, 3},
- {FileFormat.PARQUET, true, 3},
- {FileFormat.AVRO, false, 1},
- {FileFormat.AVRO, false, 2},
- {FileFormat.AVRO, false, 3},
- {FileFormat.ORC, false, 1},
- {FileFormat.ORC, true, 1},
- {FileFormat.ORC, false, 2},
- {FileFormat.ORC, true, 2},
- {FileFormat.ORC, false, 3},
- {FileFormat.ORC, true, 3},
- };
+ List<Object[]> parameters = Lists.newArrayList();
+ for (int version : TestHelpers.ALL_VERSIONS) {
+ parameters.add(new Object[] {FileFormat.PARQUET, false, version});
+ parameters.add(new Object[] {FileFormat.PARQUET, true, version});
+ parameters.add(new Object[] {FileFormat.AVRO, false, version});
+ parameters.add(new Object[] {FileFormat.ORC, false, version});
+ parameters.add(new Object[] {FileFormat.ORC, true, version});
+ }
+ return parameters.toArray(new Object[0][]);
Review Comment:
Why are we only updating v3.4? What about v4.0 and v3.5?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
