RussellSpitzer commented on code in PR #13880:
URL: https://github.com/apache/iceberg/pull/13880#discussion_r2289460446
##########
spark/v3.4/spark/src/test/java/org/apache/iceberg/spark/source/TestSparkReaderDeletes.java:
##########
@@ -107,14 +107,16 @@ public class TestSparkReaderDeletes extends
DeleteReadTests {
@Parameters(name = "fileFormat = {0}, formatVersion = {1}, vectorized = {2},
planningMode = {3}")
public static Object[][] parameters() {
- return new Object[][] {
- new Object[] {FileFormat.PARQUET, 2, false, PlanningMode.DISTRIBUTED},
- new Object[] {FileFormat.PARQUET, 2, true, PlanningMode.LOCAL},
- new Object[] {FileFormat.ORC, 2, false, PlanningMode.DISTRIBUTED},
- new Object[] {FileFormat.AVRO, 2, false, PlanningMode.LOCAL},
- new Object[] {FileFormat.PARQUET, 3, false, PlanningMode.DISTRIBUTED},
- new Object[] {FileFormat.PARQUET, 3, true, PlanningMode.LOCAL},
- };
+ List<Object[]> parameters = Lists.newArrayList();
Review Comment:
We had a really weird pattern of what we tested here before, I mimicked it
below, only testing V4 with parquet
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
