vaultah commented on code in PR #13720:
URL: https://github.com/apache/iceberg/pull/13720#discussion_r2292167860
##########
core/src/main/java/org/apache/iceberg/RewriteTablePathUtil.java:
##########
@@ -276,6 +287,62 @@ public static RewriteResult<ManifestFile>
rewriteManifestList(
}
}
+ /**
+ * Rewrite a manifest list representing a snapshot, replacing path
references.
+ *
+ * @param snapshot snapshot represented by the manifest list
+ * @param io file io
+ * @param tableMetadata metadata of table
+ * @param rewrittenManifestLengths rewritten manifest files and their sizes
+ * @param sourcePrefix source prefix that will be replaced
+ * @param targetPrefix target prefix that will replace it
+ * @param outputPath location to write the manifest list
+ */
+ public static void rewriteManifestList(
Review Comment:
I think this method is too low-level for `RewriteTablePathSparkAction` and
moving it there would scatter logic even more, also it uses `ManifestLists`
that's not public in `org.apache.iceberg` and can't be imported to
`RewriteTablePathSparkAction` that's in `org.apache.iceberg.spark.actions`. We
could move most of `RewriteTablePathUtil.rewriteManifestList` logic and only
keep a small wrapper method around `ManifestLists.write`, or make
`ManifestLists` public. Let me know how you'd like to proceed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
