dramaticlly commented on code in PR #13720:
URL: https://github.com/apache/iceberg/pull/13720#discussion_r2292130882


##########
core/src/main/java/org/apache/iceberg/RewriteTablePathUtil.java:
##########
@@ -276,6 +287,62 @@ public static RewriteResult<ManifestFile> 
rewriteManifestList(
     }
   }
 
+  /**
+   * Rewrite a manifest list representing a snapshot, replacing path 
references.
+   *
+   * @param snapshot snapshot represented by the manifest list
+   * @param io file io
+   * @param tableMetadata metadata of table
+   * @param rewrittenManifestLengths rewritten manifest files and their sizes
+   * @param sourcePrefix source prefix that will be replaced
+   * @param targetPrefix target prefix that will replace it
+   * @param outputPath location to write the manifest list
+   */
+  public static void rewriteManifestList(

Review Comment:
   Actually I think the reason why this is here is because the 
[ManifestLists.write()](https://github.com/apache/iceberg/blob/b38573dcfb4a5467a70c28573a2d39874718a2a1/core/src/main/java/org/apache/iceberg/ManifestLists.java#L50)
 is package local, so only RewriteTablePathUtil can access but not for 
RewriteTablePathSparkAction.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to