slfan1989 commented on code in PR #13795:
URL: https://github.com/apache/iceberg/pull/13795#discussion_r2286694679
##########
flink/v2.0/flink/src/test/java/org/apache/iceberg/flink/maintenance/api/TestZkLockFactory.java:
##########
@@ -39,15 +51,13 @@ void before() {
super.before();
}
- @Override
- TriggerLockFactory lockFactory() {
- return new ZkLockFactory(zkTestServer.getConnectString(), testLockId,
5000, 3000, 1000, 3);
+ ZkLockFactory lockFactory(String lockId) {
Review Comment:
Thank you for pointing this out. You are right, my original code was not
ideal, and I have modified it according to your suggestion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
