pvary commented on code in PR #13795:
URL: https://github.com/apache/iceberg/pull/13795#discussion_r2282521522
##########
flink/v2.0/flink/src/test/java/org/apache/iceberg/flink/maintenance/api/TestLockFactoryBase.java:
##########
@@ -30,6 +30,8 @@ abstract class TestLockFactoryBase {
abstract TriggerLockFactory lockFactory();
+ abstract TriggerLockFactory createOtherLockFactory(String tableName);
Review Comment:
Better to have a single `abstract TriggerLockFactory lockFactory(String
tableName);` than having 2 abstract methods which have to be implemented by the
concrete test classes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
