RussellSpitzer commented on code in PR #13137:
URL: https://github.com/apache/iceberg/pull/13137#discussion_r2286102930
##########
api/src/test/java/org/apache/iceberg/variants/VariantTestUtil.java:
##########
@@ -119,7 +123,7 @@ private static int writeBufferAbsolute(ByteBuffer buffer,
int offset, ByteBuffer
}
/** Creates a random string primitive of the given length for forcing large
offset sizes */
- static SerializedPrimitive createString(String string) {
+ public static VariantPrimitive<?> createString(String string) {
Review Comment:
Why the signature change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
