huaxingao commented on code in PR #13804:
URL: https://github.com/apache/iceberg/pull/13804#discussion_r2282887897
##########
spark/v4.0/spark/src/test/java/org/apache/iceberg/spark/sql/TestSelect.java:
##########
@@ -613,4 +613,21 @@ public void testComplexTypeFilter() {
assertEquals("Should return all expected rows", ImmutableList.of(row(1)),
result);
sql("DROP TABLE IF EXISTS %s", complexTypeTableName);
}
+
+ @TestTemplate
+ public void testRequiredNestedFieldInOptionalStructFilter() {
+ String nestedStructTable = tableName("nested_struct_table");
+ sql(
+ "CREATE TABLE %s (id INT NOT NULL, address STRUCT<street: STRING NOT
NULL>)"
Review Comment:
nit: add an empty space in the end?
##########
spark/v4.0/spark/src/test/java/org/apache/iceberg/spark/sql/TestSelect.java:
##########
@@ -613,4 +613,21 @@ public void testComplexTypeFilter() {
assertEquals("Should return all expected rows", ImmutableList.of(row(1)),
result);
sql("DROP TABLE IF EXISTS %s", complexTypeTableName);
}
+
+ @TestTemplate
+ public void testRequiredNestedFieldInOptionalStructFilter() {
+ String nestedStructTable = tableName("nested_struct_table");
+ sql(
+ "CREATE TABLE %s (id INT NOT NULL, address STRUCT<street: STRING NOT
NULL>)"
+ + "USING iceberg ",
Review Comment:
nit: remove the empty space from the end?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
