nastra commented on code in PR #13804:
URL: https://github.com/apache/iceberg/pull/13804#discussion_r2292641039
##########
.palantir/revapi.yml:
##########
@@ -1254,6 +1254,10 @@ acceptedBreaks:
new: "method void
org.apache.iceberg.data.parquet.BaseParquetWriter<T>::<init>()"
justification: "Changing deprecated code"
"1.9.0":
+ org.apache.iceberg:iceberg-api:
Review Comment:
we shouldn't be breaking the API when introducing new methods (see also
https://iceberg.apache.org/contribute/#adding-new-functionality-without-breaking-apis).
Please add a default impl to the method and remove the API breakage exception
from this file
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
