Guosmilesmile commented on code in PR #13832:
URL: https://github.com/apache/iceberg/pull/13832#discussion_r2281411573
##########
flink/v2.0/flink/src/main/java/org/apache/iceberg/flink/maintenance/api/RewriteDataFilesConfig.java:
##########
@@ -31,39 +31,73 @@
public class RewriteDataFilesConfig {
public static final String PREFIX = FlinkMaintenanceConfig.PREFIX +
"rewrite.";
+ // Configuration option for maximum rewrite bytes
public static final String MAX_BYTES = PREFIX + "max-bytes";
public static final ConfigOption<Long> MAX_BYTES_OPTION =
- ConfigOptions.key(MAX_BYTES).longType().defaultValue(Long.MAX_VALUE);
+ ConfigOptions.key(MAX_BYTES)
+ .longType()
+ .defaultValue(Long.MAX_VALUE)
+ .withDescription(
+ "The maximum number of bytes allowed for the rewrite operation. "
+ + "If the total size of the data files to be rewritten
exceeds this value, "
+ + "the rewrite operation will be split into multiple
parts.");
Review Comment:
Instead of using "multiple parts," which can be ambiguous, it would be
clearer to say "The rewrites for one scheduled compaction are limited in size
to restrict the resources used by the compaction."
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
