slfan1989 commented on PR #13832: URL: https://github.com/apache/iceberg/pull/13832#issuecomment-3194911586
@pvary @Guosmilesmile @mxm @stevenzwu I’ve researched #12979, and I think this PR is a very important improvement — thank you for the great contribution! However, I noticed a small issue: typically, Flink configurations include a description field. I believe we should add the specific meaning of the configuration to this field so that other developers can better understand its purpose when reading the code. After looking into the code, I’ve supplemented this part of the functionality. Could you please help review this PR again? Thank you very much! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
