HeartLinked commented on code in PR #178: URL: https://github.com/apache/iceberg-cpp/pull/178#discussion_r2281173287
########## src/iceberg/manifest_reader_internal.h: ########## @@ -22,6 +22,8 @@ /// \file iceberg/internal/manifest_reader_internal.h /// Reader implementation for manifest list files and manifest files. +#include "iceberg/file_reader.h" Review Comment: It seems that std::unique_ptr<Reader> the Reader here is provided by the file_reader.h, and removing the inclusion of this header file will cause an error. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
