HeartLinked commented on code in PR #178:
URL: https://github.com/apache/iceberg-cpp/pull/178#discussion_r2281157515
##########
src/iceberg/manifest_reader_internal.h:
##########
@@ -30,14 +32,20 @@ namespace iceberg {
class ManifestReaderImpl : public ManifestReader {
public:
explicit ManifestReaderImpl(std::unique_ptr<Reader> reader,
- std::shared_ptr<Schema> schema)
- : schema_(std::move(schema)), reader_(std::move(reader)) {}
+ std::shared_ptr<Schema> schema,
+ std::unique_ptr<InheritableMetadata>
inheritable_metadata)
+ : schema_(std::move(schema)),
+ reader_(std::move(reader)),
+ inheritable_metadata_(std::move(inheritable_metadata)) {}
+
+ ManifestReaderImpl() = default;
Review Comment:
fixed.
##########
src/iceberg/manifest_reader_internal.h:
##########
@@ -46,6 +54,7 @@ class ManifestListReaderImpl : public ManifestListReader {
explicit ManifestListReaderImpl(std::unique_ptr<Reader> reader,
std::shared_ptr<Schema> schema)
: schema_(std::move(schema)), reader_(std::move(reader)) {}
+ ManifestListReaderImpl() = default;
Review Comment:
fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
