slfan1989 commented on code in PR #13772:
URL: https://github.com/apache/iceberg/pull/13772#discussion_r2272075718
##########
.baseline/checkstyle/checkstyle.xml:
##########
@@ -92,6 +92,10 @@
<property name="format"
value="^\s*import\s+static\s+(?!\Qorg.assertj.core.api.Assertions.\E).*\.assertThatThrownBy;"/>
<property name="message" value="assertThatThrownBy() should be
statically imported from org.assertj.core.api.Assertions"/>
</module>
+ <module name="RegexpMultiline">
+ <property name="format"
value="^\s*import\s+static\s+org\.junit\.jupiter\.api\.Assertions\.\w+;"/>
+ <property name="message" value="Static import of JUnit 5 assertions
(org.junit.jupiter.api.Assertions) is prohibited. Use
org.assertj.core.api.Assertions methods instead (e.g., import static
org.assertj.core.api.Assertions.assertThat)."/>
Review Comment:
Thank you for making the changes. LGTM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
