slfan1989 commented on code in PR #13772: URL: https://github.com/apache/iceberg/pull/13772#discussion_r2268616917
########## flink/v1.19/flink/src/test/java/org/apache/iceberg/flink/sink/dynamic/TestRowDataConverter.java: ########## @@ -21,7 +21,7 @@ import static org.apache.iceberg.types.Types.NestedField.optional; import static org.apache.iceberg.types.Types.NestedField.required; import static org.assertj.core.api.Assertions.assertThat; -import static org.junit.jupiter.api.Assertions.assertThrows; +import static org.assertj.core.api.Assertions.assertThatThrownBy; Review Comment: Thank you for reviewing the code! I tested it locally and found that the BanJUnit5Assertions rule doesn't work properly when using `import static org.junit.jupiter.api.Assertions.assertThrows`. Do we need to add a new rule to prevent importing methods from `import static org.junit.jupiter.api.Assertions.*`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
