zhjwpku commented on code in PR #156:
URL: https://github.com/apache/iceberg-cpp/pull/156#discussion_r2259339955
##########
src/iceberg/transform_function.h:
##########
@@ -97,11 +97,11 @@ class YearTransform : public TransformFunction {
/// \param source_type Must be a timestamp type.
explicit YearTransform(std::shared_ptr<Type> const& source_type);
- /// \brief Extracts the year from each timestamp in the input array.
- Result<ArrowArray> Transform(const ArrowArray& input) override;
+ /// \brief Extract a date or timestamp year, as years from 1970.
Review Comment:
I agree the comment is not clear, but that's from the spec, see [1]. We
might also want to change the spec if it's not clear.
[1] https://iceberg.apache.org/spec/#partition-transforms
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
