zhjwpku commented on code in PR #156:
URL: https://github.com/apache/iceberg-cpp/pull/156#discussion_r2254789352
##########
src/iceberg/transform.h:
##########
@@ -170,8 +172,8 @@ class ICEBERG_EXPORT TransformFunction {
public:
virtual ~TransformFunction() = default;
TransformFunction(TransformType transform_type, std::shared_ptr<Type>
source_type);
- /// \brief Transform an input array to a new array
- virtual Result<ArrowArray> Transform(const ArrowArray& data) = 0;
+ /// \brief Transform an input Literal to a new Literal
+ virtual Result<std::optional<Literal>> Transform(const Literal& literal) = 0;
Review Comment:
I add a NullType and Literal::Null(), I use `Null` because spec says void
transform `Always produces null`.
NullType is inherited from PrimitiveType because Literal holds a
PrimitiveType shared ptr.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
