rdblue commented on code in PR #12298:
URL: https://github.com/apache/iceberg/pull/12298#discussion_r2258311390
##########
parquet/src/main/java/org/apache/iceberg/parquet/Parquet.java:
##########
@@ -136,6 +138,15 @@ private Parquet() {}
"parquet.read.support.class",
"parquet.crypto.factory.class");
+ private static final int MAX_RECORDS_PER_BATCH_DEFAULT = 10000;
+
+ public static final String WRITER_VERSION_KEY = "parquet.writer.version";
+
+ /**
+ * @deprecated Since 1.10.0, will be removed in 1.11.0. Use {@link
+ * FormatModelRegistry#writeBuilder(FileFormat, String,
EncryptedOutputFile)} instead.
+ */
+ @Deprecated
Review Comment:
My rationale is that this module contains code for working with Parquet
using Iceberg constructs like schema and table properties. We want data and
delete files to be written through the new interfaces, but this is just
creating a Parquet file writer for some purpose. This seems like a core part of
what the module does so I would not force people to register and use an object
model to create a Parquet file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
