pvary commented on code in PR #12298:
URL: https://github.com/apache/iceberg/pull/12298#discussion_r2255237671
##########
parquet/src/main/java/org/apache/iceberg/parquet/Parquet.java:
##########
@@ -136,6 +138,15 @@ private Parquet() {}
"parquet.read.support.class",
"parquet.crypto.factory.class");
+ private static final int MAX_RECORDS_PER_BATCH_DEFAULT = 10000;
+
+ public static final String WRITER_VERSION_KEY = "parquet.writer.version";
+
+ /**
+ * @deprecated Since 1.10.0, will be removed in 1.11.0. Use {@link
+ * FormatModelRegistry#writeBuilder(FileFormat, String,
EncryptedOutputFile)} instead.
+ */
+ @Deprecated
Review Comment:
What are the use-cases for this? We can expose the new implementation class
with the required methods if it is necessary, but the goal of the API is to
provide a generalized interface for the users of the writers. Maybe the use
case is generic enough to expose it through the `WriterBuilder` interface.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
