nastra commented on code in PR #13562:
URL: https://github.com/apache/iceberg/pull/13562#discussion_r2253689609
##########
arrow/src/main/java/org/apache/iceberg/arrow/vectorized/VectorizedArrowReader.java:
##########
@@ -508,6 +440,168 @@ public static VectorizedReader<?>
replaceWithMetadataReader(
return reader;
}
+ private static final class LogicalTypeVisitorResult {
Review Comment:
ah nvm, I thought we're avoiding using `final` on classes in the codebase
but it appears that we have plenty of examples of final classes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
