nandorKollar commented on code in PR #13562:
URL: https://github.com/apache/iceberg/pull/13562#discussion_r2253445718
##########
arrow/src/main/java/org/apache/iceberg/arrow/vectorized/VectorizedArrowReader.java:
##########
@@ -508,6 +440,168 @@ public static VectorizedReader<?>
replaceWithMetadataReader(
return reader;
}
+ private static final class LogicalTypeVisitorResult {
Review Comment:
This class is intended to be used only for a very specific, internal
purpose, that's why I marked it final. It isn't intended for extension,
basically using 'record' type would be more accurate here, but that's not
present in Java 11. If we would like to inherit from this sometime in the
future, we can then remove the final modifier. Could you please explain why do
you think it is better not to mark this final?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
