raunaqmorarka commented on issue #12590: URL: https://github.com/apache/iceberg/issues/12590#issuecomment-3148661338
> > There is also a WIP PR [trinodb/trino#26230](https://github.com/trinodb/trino/pull/26230) to use separate thread pool and increase parallelism for expire_snapshots > > Will that PR cover all DELETE paths? That PR covers expire_snapshots, https://github.com/trinodb/trino/pull/26326 covers remove_orphan_files. The code in `org.apache.iceberg.CatalogUtil#deleteFiles(org.apache.iceberg.io.FileIO, java.util.Set<org.apache.iceberg.ManifestFile>)` is used only for DROP TABLE operations in Trino. I think the right solution for that would be to allow the caller to pass in their own ExecutorService into `org.apache.iceberg.CatalogUtil#dropTableData` rather than shifting it into another internal threadpool of iceberg library. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
