nastra commented on code in PR #13700:
URL: https://github.com/apache/iceberg/pull/13700#discussion_r2247204723
##########
arrow/src/test/java/org/apache/iceberg/arrow/vectorized/TestArrowReader.java:
##########
@@ -698,7 +720,9 @@ private void writeTable(boolean constantRecords) throws
Exception {
Types.NestedField.required(24, "uuid", Types.UUIDType.get()),
Types.NestedField.optional(25, "uuid_nullable",
Types.UUIDType.get()),
Types.NestedField.required(26, "decimal", Types.DecimalType.of(9,
2)),
- Types.NestedField.optional(27, "decimal_nullable",
Types.DecimalType.of(9, 2)));
+ Types.NestedField.optional(27, "decimal_nullable",
Types.DecimalType.of(9, 2)),
+ Types.NestedField.required(28, "fixed",
Types.FixedType.ofLength(7)),
Review Comment:
nit: maybe also use different lengths for both fields
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
