nastra commented on code in PR #13700:
URL: https://github.com/apache/iceberg/pull/13700#discussion_r2247201361
##########
arrow/src/test/java/org/apache/iceberg/arrow/vectorized/TestArrowReader.java:
##########
@@ -828,6 +857,8 @@ private List<GenericRecord> createIncrementalRecordsForDate(
rec.setField("uuid_nullable", uuid);
rec.setField("decimal", new BigDecimal("14.0" + i % 10));
rec.setField("decimal_nullable", new BigDecimal("14.0" + i % 10));
+ rec.setField("fixed", new byte[] {1, 2, 3, 4, 5, 6, (byte) i});
Review Comment:
nit: I'd maybe just define a string and convert it to its binary
representation (same as we do a few lines above for `bytes`:
```
rec.setField("fixed", ("abc" + i).getBytes(StandardCharsets.UTF_8));
rec.setField("fixed_nullable", ("abcdef" +
i).getBytes(StandardCharsets.UTF_8));
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
