ForeverAngry commented on PR #2143: URL: https://github.com/apache/iceberg-python/pull/2143#issuecomment-3138044961
> > Would it be better to avoid duplication in the API? so something like this instead? > > table.maintenance().expire_snapshots().by_ids() > > i like that! > > Looks similar to java/spark too https://iceberg.apache.org/docs/latest/maintenance/#expire-snapshots > > ``` > table.expireSnapshots() > .expireOlderThan(tsToExpire) > .commit(); > ``` > > @ForeverAngry wdyt? I dont think i feel strongly one way or the other. I'm happy to make the adjustments. Let me know what you want to do @kevinjqliu . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
