ForeverAngry commented on PR #2143: URL: https://github.com/apache/iceberg-python/pull/2143#issuecomment-3129244930
> im curious what you and others think of the API design here. > > I like that we're using `MaintenanceTable`/`table.maintenance()` to encapsulate all maintenance related functions. Right now, all the maintenance operations are top-level functions of `MaintenanceTable`. Im wondering if we should extend the API to include individual maintenance operations. > > For example, > > ``` > table.maintenance().expire_snapshots() > ``` > > and > > ``` > table.maintenance().expire_snapshots().expire_snapshots_by_ids() > ``` > > This also set up a good pattern for other maintenance operations. WDYT? > > Sidenote, i spelled `maintenance` wrong several times while typing this. Should we consider something like `maintain` instead? :) yeah, I admit - i've misspelled it a number of times lol -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
