manirajv06 commented on code in PR #13195:
URL: https://github.com/apache/iceberg/pull/13195#discussion_r2243244315
##########
api/src/main/java/org/apache/iceberg/expressions/VariantExpressionUtil.java:
##########
@@ -111,8 +113,19 @@ static <T> T castTo(VariantValue value, Type type) {
}
break;
- }
+ case TIMESTAMP:
+ case TIMESTAMP_NANO:
+ case TIME:
+ if (value.type() == PhysicalType.INT64) {
+ return (T) (Long) ((Number) value.asPrimitive().get()).longValue();
+ }
+ break;
+ case UUID:
Review Comment:
Ok. Since there is no conversion used in `UUIDLiteral`, we don't want to do
any conversions here as well.
Even for expression with UUID type and UUID literal, Comparators needs to be
revisited again. As mentioned earlier, I am not sure whether Natural
comparators would be the right approach. Please clarify on this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
