aihuaxu commented on code in PR #13195:
URL: https://github.com/apache/iceberg/pull/13195#discussion_r2280554552
##########
api/src/main/java/org/apache/iceberg/expressions/VariantExpressionUtil.java:
##########
@@ -111,8 +113,19 @@ static <T> T castTo(VariantValue value, Type type) {
}
break;
- }
+ case TIMESTAMP:
+ case TIMESTAMP_NANO:
+ case TIME:
Review Comment:
I see. It's to fix some common issues: so seems TIMESTAMP => TIMESTAMP_NANO
should be supported. Is TIME => TIMESTAMP / TIMESTAMP_NANO allowed - maybe not?
> * <p>When a predicate is bound to a concrete data column, literals are
converted to match the
> * bound column's type. This conversion process is more narrow than a
cast and is only intended
> * for cases where substituting one type is a common mistake (e.g. 34
instead of 34L) or where
> * this API avoids requiring a concrete class (e.g., dates).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
