liurenjie1024 commented on code in PR #1521:
URL: https://github.com/apache/iceberg-rust/pull/1521#discussion_r2241325290
##########
crates/iceberg/src/catalog/memory/catalog.rs:
##########
@@ -280,7 +280,11 @@ impl Catalog for MemoryCatalog {
&self,
table_ident: &TableIdent,
metadata_location: String,
+ overwrite: Option<bool>,
) -> Result<Table> {
+ // TODO: Use overwrite in `insert_new_table` to overwrite metadata for
an already existing table
Review Comment:
Sorry, I mean adding an argument to `Catalog` trait's `register_table`
method is a breaking change, and we should not do it for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
