liurenjie1024 commented on code in PR #1521:
URL: https://github.com/apache/iceberg-rust/pull/1521#discussion_r2239215001
##########
crates/iceberg/src/catalog/memory/catalog.rs:
##########
@@ -280,7 +280,11 @@ impl Catalog for MemoryCatalog {
&self,
table_ident: &TableIdent,
metadata_location: String,
+ overwrite: Option<bool>,
) -> Result<Table> {
+ // TODO: Use overwrite in `insert_new_table` to overwrite metadata for
an already existing table
Review Comment:
This is a breaking change, and I would not do it now. We can just pass
`overwrite=false` to remote catalog. Currently java didn't support overwrite
in api, and I don't think we need to do it now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
