rdblue commented on code in PR #13039:
URL: https://github.com/apache/iceberg/pull/13039#discussion_r2241246445
##########
core/src/main/java/org/apache/iceberg/MetricsConfig.java:
##########
@@ -107,6 +115,81 @@ public static MetricsConfig forPositionDelete(Table table)
{
return new MetricsConfig(columnModes.build(), defaultMode);
}
+ static Iterable<Integer> breadthFirstFieldPriority(Schema schema) {
+ return TypeUtil.visit(
+ schema,
+ new TypeUtil.CustomOrderSchemaVisitor<>() {
+
+ @Override
+ public Iterable<Integer> schema(Schema schema,
Supplier<Iterable<Integer>> structResult) {
+ return structResult.get();
+ }
+
+ @Override
+ public Iterable<Integer> struct(
+ Types.StructType struct, Iterable<Iterable<Integer>>
fieldResults) {
+
+ List<Integer> orderedFieldIds =
+ Lists.newArrayListWithExpectedSize(struct.fields().size());
+ for (Types.NestedField field : struct.fields()) {
+ if (field.type().isPrimitiveType()) {
+ orderedFieldIds.add(field.fieldId());
+ }
+ }
+ return Iterables.concat(orderedFieldIds,
Iterables.concat(fieldResults));
Review Comment:
Style: Iceberg's convention is to leave an empty newline between control
flow blocks and the following statement.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
