jkolash opened a new pull request, #13039:
URL: https://github.com/apache/iceberg/pull/13039

   These changes address issue #11253 allowing for setting of a new default 
strategy that considers the total number of field metrics rather than just the 
number of top level columns.
   
   the new property is
   ```write.metadata.metrics.max-inferred-column-defaults.strategy```
   
   and valid values would be ```original, depth, breadth```
   
   It currently preserves the original default behavior as changing
   that may be a more disruptive change as it could lead to unexpected
   performance regressions. A Breadth first strategy would likely be most
   compatible with the original strategy so it would be safer to default
   into vs the depth strategy. The original strategy could then be
   deprecated and removed in the future
   
   This could also easily support a previously discussed feature of
   reversing order of field ids for considering defaults. Though that
   won't be included in this PR
   
   I'm inclined to remove the depth strategy unless there is a strong
   desire to keep it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to