kevinjqliu commented on PR #2029: URL: https://github.com/apache/iceberg-python/pull/2029#issuecomment-3127823424
> Like why you disappeared for weeks to then take over the PR, this doesn't look right to be honest. hey @Erigara sorry about the chain of event. I started a new job recently and didnt have time to review this PR before. I pushed to the PR because I wanted to get the 0.10 release out to the community. We [started the discussion](https://lists.apache.org/thread/o2wcs9774rm1krswjgm55sjhgdczyzxl) in the beginning of July and multiple community members has asked about the release date. This was one of the last remaining bugs that I think would be good to include in the release. Hope you can understand that Im trying to balance community goals and individual PR contributions. Regarding the implementation using `_ColumnNameTranslator`. Originally I [had concerns](https://github.com/apache/iceberg-python/pull/2029#discussion_r2173819438) about this. #1644 was then merged with `initial-defaults` projection in the same place. So it make sense to now colocate the two. I still think its still not the best place for the column projection logic. Happy to iterate on this together. Im trying to make sure we hit all the corner cases so we can fix the original bug and release 0.10. We can come back to refactor this code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
