nandorKollar commented on code in PR #13562:
URL: https://github.com/apache/iceberg/pull/13562#discussion_r2235542953
##########
arrow/src/main/java/org/apache/iceberg/arrow/vectorized/VectorizedArrowReader.java:
##########
@@ -180,6 +184,7 @@ public VectorHolder read(VectorHolder reuse, int
numValsToRead) {
.nextBatch(vec, typeWidth, nullabilityHolder);
break;
case TIMESTAMP_MILLIS:
+ case TIMESTAMP_NANOS:
vectorizedColumnIterator
.timestampMillisBatchReader()
Review Comment:
Yes, actually I came to the same conclusion, nevertheless I would like to
understand why do we need `timestampMillisBatchReader` for millis, and not for
micros. Is it because we need to transform millis to micros, because Iceberg
timestamp type represents microsecond precision? If so, then I think this line
is indeed not needed, as we're reading timestamp nanos here, no transformation
is needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
