pvary commented on code in PR #13562:
URL: https://github.com/apache/iceberg/pull/13562#discussion_r2228860705
##########
arrow/src/main/java/org/apache/iceberg/arrow/vectorized/VectorizedArrowReader.java:
##########
@@ -180,6 +184,7 @@ public VectorHolder read(VectorHolder reuse, int
numValsToRead) {
.nextBatch(vec, typeWidth, nullabilityHolder);
break;
case TIMESTAMP_MILLIS:
+ case TIMESTAMP_NANOS:
vectorizedColumnIterator
.timestampMillisBatchReader()
Review Comment:
Checked, and starting to have doubts that this is working as expected.
the `timestampMillisBatchReader` ends up returning
`VectorizedParquetDefinitionLevelReader.TimestampMillisReader` where:
```
@Override
protected void nextVal(
FieldVector vector,
int idx,
VectorizedValuesReader valuesReader,
int typeWidth,
byte[] byteArray) {
vector.getDataBuffer().setLong((long) idx * typeWidth,
valuesReader.readLong() * 1000);
}
```
So it is very much millis
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
