nastra commented on code in PR #13590:
URL: https://github.com/apache/iceberg/pull/13590#discussion_r2235016399


##########
data/src/test/java/org/apache/iceberg/data/avro/TestGenericData.java:
##########
@@ -56,8 +54,7 @@ protected void writeAndValidate(Schema writeSchema, Schema 
expectedSchema) throw
   private void writeAndValidate(Schema writeSchema, Schema expectedSchema, 
List<Record> expected)
       throws IOException {
 
-    File testFile = File.createTempFile("junit", null, temp.toFile());
-    assertThat(testFile.delete()).isTrue();
+    File testFile = temp.resolve("test-file").toFile();

Review Comment:
   this (and a few other places that do `temp.resolve("test-file").toFile()`) 
should have a random component just to make sure we use unique files



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to