nastra commented on code in PR #13590:
URL: https://github.com/apache/iceberg/pull/13590#discussion_r2218438402
##########
core/src/test/java/org/apache/iceberg/hadoop/TestHadoopFileIO.java:
##########
@@ -214,7 +214,7 @@ private static void testJsonParser(HadoopFileIO
hadoopFileIO, File tempDir) thro
// make sure deserialized io can create input file
Files.createTempDirectory(tempDir.toPath(), "junit");
deserializedHadoopFileIO.newInputFile(
- File.createTempFile("test", "parquet", tempDir).toString());
+ tempDir.toPath().resolve("test" + System.nanoTime() +
".parquet").toFile().toString());
Review Comment:
instead of converting to a Path and then back to a file, this is probably
shorter: `new File(tempDir, "test" + System.nanoTime() + ".parquet")`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
