gaborkaszab commented on PR #13569: URL: https://github.com/apache/iceberg/pull/13569#issuecomment-3117961208
I did the adjustments for the test changes. I also discussed the `boolean` vs `Boolean` question with @nastra . We agreed that it in fact makes sense to differentiate between the field not provided or provided but false. My reasoning is that if it's not provided we can use the default value in the Java API of ExpireSnapshots. Otherwise if we didn't have this distinction and the value of the Flag would be false (and not null) in Flink then changing the default value would be error-prone: We'd have to remember changing it in 3 place: Java API, Flink and Spark. If this was `Boolean` then only changing in the Java API would be necessary. Pinging @mxm because you also leant towards having primitive boolean instead. Do you think you can go with the above reasoning? If there is a consensus, I'll adjust the Spark code to also reflect this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org