pvary commented on code in PR #13569:
URL: https://github.com/apache/iceberg/pull/13569#discussion_r2212931445
##########
flink/v2.0/flink/src/main/java/org/apache/iceberg/flink/maintenance/api/ExpireSnapshots.java:
##########
@@ -46,6 +46,7 @@ public static class Builder extends
MaintenanceTaskBuilder<ExpireSnapshots.Build
private Integer numSnapshots = null;
private Integer planningWorkerPoolSize;
private int deleteBatchSize = DELETE_BATCH_SIZE_DEFAULT;
+ private Boolean cleanExpiredMetadata = null;
Review Comment:
This means that if we change the default value, then we will have to change
in 2 separate places (Spark and Flink).
Since we made the decision on the Spark side, we should behave the same
here, but I see the logic with having an object instead of the primitive value
here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
