rdblue commented on code in PR #13195: URL: https://github.com/apache/iceberg/pull/13195#discussion_r2229804059
########## core/src/test/java/org/apache/iceberg/expressions/TestInclusiveMetricsEvaluatorWithExtract.java: ########## @@ -68,6 +76,72 @@ public class TestInclusiveMetricsEvaluatorWithExtract { private static final int INT_MIN_VALUE = 30; private static final int INT_MAX_VALUE = 79; + private static final OffsetDateTime TS_COMMON_MIN_VALUE = Review Comment: Tests should always use raw values and should not perform time zone calculations. Date/time calculations are delegated to engines. Iceberg should always work with concrete values. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org