RussellSpitzer commented on code in PR #13631:
URL: https://github.com/apache/iceberg/pull/13631#discussion_r2228373533
##########
core/src/main/java/org/apache/iceberg/BaseTransaction.java:
##########
@@ -121,180 +121,143 @@ public TableOperations underlyingOps() {
return ops;
}
- private void checkLastOperationCommitted(String operation) {
+ protected <T extends PendingUpdate> T appendUpdates(T update) {
+ if (!(update instanceof ManageSnapshots)) {
Review Comment:
Polymorphism I think would be ok as long as we are sure the inheritance tree
isn't going to get weird, but callback would be way too open imho. I think
ideally we want the logic of how something get's dealt with by class details to
stay protected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
