pvary commented on code in PR #13631:
URL: https://github.com/apache/iceberg/pull/13631#discussion_r2227935803
##########
core/src/main/java/org/apache/iceberg/BaseTransaction.java:
##########
@@ -121,180 +121,143 @@ public TableOperations underlyingOps() {
return ops;
}
- private void checkLastOperationCommitted(String operation) {
+ protected <T extends PendingUpdate> T appendUpdates(T update) {
+ if (!(update instanceof ManageSnapshots)) {
Review Comment:
I usually thy to avoid using `instanceof`.
Could we just use java polymorphism? Like:
```
protected SnapshotUpdate appendUpdates(SnapshotUpdate update) {
update.deleteWith(enqueueDelete);
updates.add(update);
return update;
}
protected SnapshotProducer appendUpdates(SnapshotProducer update) {
update.reportWith(reporter);
updates.add(update);
return update;
}
protected ManageSnapshots appendUpdates(ManageSnapshots update) {
checkLastOperationCommitted(update.getClass().getSimpleName());
updates.add(update);
return update;
}
protected PendingUpdate appendUpdates(PendingUpdate update) {
updates.add(update);
return update;
}
```
Or could we just a callback method, like:
```
protected <T extends PendingUpdate> T appendUpdates(T update, Consumer<T>
consumer) {
consumer.accept(update);
updates.add(update);
return update;
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
