pvary commented on code in PR #13497:
URL: https://github.com/apache/iceberg/pull/13497#discussion_r2227971256
##########
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java:
##########
@@ -221,9 +230,20 @@ public boolean dropTable(TableIdentifier identifier,
boolean purge) {
TableOperations ops = newTableOps(identifier);
TableMetadata lastMetadata = null;
- if (purge) {
+
+ LOG.info("deleteTableRootDir: {}", this.deleteTableRootDir);
+ boolean externalTablePurge = false;
+ boolean gcEnabled = false;
+
+ if (purge || this.deleteTableRootDir) {
Review Comment:
Consider it from the other perspective.
A Spark user is used to keep the table data when not using `purge`
explicitly. The proposed behavior would be strange to them.
Would an auto-purge flag in Spark be better?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
