pvary commented on code in PR #13497:
URL: https://github.com/apache/iceberg/pull/13497#discussion_r2227779327
##########
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java:
##########
@@ -221,9 +230,20 @@ public boolean dropTable(TableIdentifier identifier,
boolean purge) {
TableOperations ops = newTableOps(identifier);
TableMetadata lastMetadata = null;
- if (purge) {
+
+ LOG.info("deleteTableRootDir: {}", this.deleteTableRootDir);
+ boolean externalTablePurge = false;
+ boolean gcEnabled = false;
+
+ if (purge || this.deleteTableRootDir) {
Review Comment:
Why do we delete the table root directory if the `purge` is `false`?
Is this the expected behavior?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
