Guosmilesmile commented on code in PR #13609: URL: https://github.com/apache/iceberg/pull/13609#discussion_r2221388138
########## flink/v2.0/flink/src/main/java/org/apache/iceberg/flink/sink/dynamic/DynamicWriter.java: ########## @@ -109,8 +109,8 @@ public void write(DynamicRecordInternal element, Context context) // TODO: Handle precedence correctly for the write properties coming from // the sink conf and from the table defaults Map<String, String> tableWriteProperties = - Maps.newHashMap(commonWriteProperties); - tableWriteProperties.putAll(table.properties()); + Maps.newHashMap(table.properties()); + tableWriteProperties.putAll(commonWriteProperties); Review Comment: I made a version using FlinkConfParser. Please take a look and see if it’s appropriate. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org