mxm commented on code in PR #13609:
URL: https://github.com/apache/iceberg/pull/13609#discussion_r2218782506
##########
flink/v2.0/flink/src/main/java/org/apache/iceberg/flink/sink/dynamic/DynamicWriter.java:
##########
@@ -109,8 +109,8 @@ public void write(DynamicRecordInternal element, Context
context)
// TODO: Handle precedence correctly for the write
properties coming from
// the sink conf and from the table defaults
Map<String, String> tableWriteProperties =
- Maps.newHashMap(commonWriteProperties);
- tableWriteProperties.putAll(table.properties());
+ Maps.newHashMap(table.properties());
+ tableWriteProperties.putAll(commonWriteProperties);
Review Comment:
I wonder, should we use
https://github.com/apache/iceberg/blob/cea1093592e77ba4f9027b13a8dff5f7e1cfc6b5/flink/v2.0/flink/src/main/java/org/apache/iceberg/flink/FlinkConfParser.java#L35
here?
##########
flink/v2.0/flink/src/main/java/org/apache/iceberg/flink/sink/dynamic/DynamicWriter.java:
##########
@@ -109,8 +109,8 @@ public void write(DynamicRecordInternal element, Context
context)
// TODO: Handle precedence correctly for the write
properties coming from
// the sink conf and from the table defaults
Map<String, String> tableWriteProperties =
Review Comment:
If we addressed this, we should remove the comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
