manuzhang commented on PR #13607: URL: https://github.com/apache/iceberg/pull/13607#issuecomment-3097341024
@pan3793 The name is confusing in the context of `SparkCatalogConfig`, where we have `SPAARK_WITH_VIEWS` and `SPARK_SESSION_WITH_VIEWS`. I think we'd better be consistent here. ```Java SPARK_WITH_VIEWS( "spark_with_views", SparkCatalog.class.getName(), ImmutableMap.of( CatalogProperties.CATALOG_IMPL, InMemoryCatalog.class.getName(), "default-namespace", "default", "cache-enabled", "false")), SPARK_SESSION_WITH_VIEWS( "spark_catalog", SparkSessionCatalog.class.getName(), ImmutableMap.of("type", "rest", "default-namespace", "default", "cache-enabled", "false")); ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org