nastra commented on PR #13607: URL: https://github.com/apache/iceberg/pull/13607#issuecomment-3096080138
> The `SPARK` enum in `SparkCatalogConfig` is not consistent with its implementation, `SparkSessionCatalog`. This PR deprecates it and replaces its usage with `SPARK_SESSION`. My guess is that the enum name was chosen because when you use the SparkSessionCatalog your catalog name always must be named `spark_catalog`. I'm fine renaming the enum to `SPARK_SESSION` as this makes it clearer, but I don't think we need to deprecate anything, since this is test code -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
